Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PeerConnection] Add RTCRtpSender.setStreams() #16848

Merged
merged 1 commit into from May 30, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented May 15, 2019

This change exposes the setStreams() method of RTCRtpSender, which allows
changing the stream associations of an existing transceiver.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/g5Grj_VtF8Q

Drive-by: Fix minor lint issues.

Bug: 844386
Change-Id: I7fe463d6811d5cb74cb297bf81d5bc90040fe86a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611836
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664586}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1611836 branch 6 times, most recently from 99185d5 to d371429 May 16, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1611836 branch 4 times, most recently from 3bb125e to 0efb035 May 29, 2019
This change exposes the setStreams() method of RTCRtpSender, which allows
changing the stream associations of an existing transceiver.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/g5Grj_VtF8Q

Drive-by: Fix minor lint issues.

Bug: 844386
Change-Id: I7fe463d6811d5cb74cb297bf81d5bc90040fe86a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611836
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664586}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1611836 branch from 0efb035 to 4cf9811 May 30, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 3c82133 into master May 30, 2019
15 checks passed
15 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
website-build-and-publish website-build-and-publish
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190530.14 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1611836 branch May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.