Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NG/DL: Implement size containment (and display lock) for NG fieldset algo #16858

Merged
merged 2 commits into from Jun 12, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented May 15, 2019

This patch adds size containment implementation for fieldsets in
LayoutNG.

Tested with LayoutNGFieldset feature flag.

Along with the new tests,
external/wpt/css/css-contain/contain-size-fieldset-001.html and
external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-fieldset-001.html
are also passing.

R=chrishtr@chromium.org, ikilpatrick@chromium.org, mstensho@chromium.org

Bug: 958975
Change-Id: I5e735adc65ed9450f84e4c1ab68cba69e3fd85ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613844
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660866}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1613844 branch 2 times, most recently from 844d05a to e9edc10 May 16, 2019
@foolip foolip force-pushed the chromium-export-cl-1613844 branch from e9edc10 to f332cda Jun 4, 2019
…algo

This patch adds size containment implementation for fieldsets in
LayoutNG.

Tested with LayoutNGFieldset feature flag.

Along with the new tests,
external/wpt/css/css-contain/contain-size-fieldset-001.html and
external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-fieldset-001.html
are also passing.

R=chrishtr@chromium.org, ikilpatrick@chromium.org, mstensho@chromium.org

Bug: 958975
Change-Id: I5e735adc65ed9450f84e4c1ab68cba69e3fd85ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613844
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660866}
@foolip
Copy link
Member

foolip commented Jun 12, 2019

contain-size-fieldset-001-ref.html is already a colliding ref name and listed in lint.whitelist, so I'll add this there.

See also #17289 which
was discovered when preparing this change.
@foolip foolip force-pushed the chromium-export-cl-1613844 branch from f332cda to e200178 Jun 12, 2019
@wpt-pr-bot wpt-pr-bot added the infra label Jun 12, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 677d31b into master Jun 12, 2019
15 checks passed
15 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
website-build-and-publish website-build-and-publish
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190612.72 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1613844 branch Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.