Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Fix the NGExclusionSpaceInternal vectors going out of sync. #16860

Merged
merged 1 commit into from May 18, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented May 15, 2019

NGExclusion::operator== didn't previous compare shape_data. This turned
out to be a bad optimization. :)

Without this we'd end up in a situation where we would have:

  • An exclusion vector containing an exclusion with shape data.
  • Derived geometry which wasn't tracking shape data.

Bug: 963580
Change-Id: I21746f8fd081ff24658768ee6074122f2e913bd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613560
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661191}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1613560 branch from b8c49a1 to 151eeb3 May 18, 2019
NGExclusion::operator== didn't previous compare shape_data. This turned
out to be a bad optimization. :)

Without this we'd end up in a situation where we would have:
 - An exclusion vector containing an exclusion with shape data.
 - Derived geometry which wasn't tracking shape data.

Bug: 963580
Change-Id: I21746f8fd081ff24658768ee6074122f2e913bd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613560
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661191}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1613560 branch from 151eeb3 to 8a85c64 May 18, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9123f1c into master May 18, 2019
15 checks passed
15 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
Azure Pipelines Build #20190518.17 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1613560 branch May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.