Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale intrinsic size #16897

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented May 17, 2019

This fixes the problem of intrinsicsize not working properly with
high density device. As well, intrinsicsize not working properly
with zoom in and zoom out.

In addition, as debugging I realized the test was initially written
wrong, so I fixed the test.
I verified the test bahavior by testing it on an image without
intrinsicsize attr. In this case the image's intrinsic width / height
will be used as its intrinsic dimension. Now the intrinsic dimension
overridden by intrinsicsize attribute matches the behavior.

Bug: 957192
Change-Id: I164809544bfad9a2d36af96b536cec735295087a

Reviewed-on: https://chromium-review.googlesource.com/1613930
WPT-Export-Revision: 3633546683753388295ef30d4855e49ea8a1f228

This fixes the problem of intrinsicsize not working properly with
high density device. As well, intrinsicsize not working properly
with zoom in and zoom out.

In addition, as debugging I realized the test was initially written
wrong, so I fixed the test.
I verified the test bahavior by testing it on an image without
intrinsicsize attr. In this case the image's intrinsic width / height
will be used as its intrinsic dimension. Now the intrinsic dimension
overridden by intrinsicsize attribute matches the behavior.

Bug: 957192
Change-Id: I164809544bfad9a2d36af96b536cec735295087a
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@gsnedders gsnedders closed this Jan 24, 2020
@gsnedders gsnedders deleted the chromium-export-cl-1613930 branch Jan 24, 2020
@gsnedders gsnedders restored the chromium-export-cl-1613930 branch Jan 24, 2020
@Hexcles Hexcles reopened this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.