Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a precondition to all the element timing tests #16898

Merged
merged 1 commit into from May 18, 2019

Conversation

@jgraham
Copy link
Contributor

jgraham commented May 17, 2019

Since PerformanceObserver.observe doesn't have any way to signal an
unsupported type we end up just timing out all the tests in
implementations that doesn't support element timing. For efficiency
add a precondition to all the tests to check for the relevant API instead.

Since PerformanceObserver.observe doesn't have any way to signal an
unsupported type we end up just timing out all the tests in
implementations that doesn't support element timing. For efficiency
add a precondition to all the tests to check for the relevant API instead.
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot commented May 17, 2019

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@Hexcles Hexcles requested a review from npm1 May 17, 2019
@npm1
npm1 approved these changes May 17, 2019
Copy link
Contributor

npm1 left a comment

LGTM
We recently added PerformanceObserver.supportedEntryTypes. However since it's a new addition then a check like this might work better for now.

@jgraham jgraham merged commit 163424c into master May 18, 2019
15 checks passed
15 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
website-build-and-publish website-build-and-publish
Details
wpt.fyi - firefox[experimental] Firefox results
Details
Azure Pipelines Build #20190517.38 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - safari[experimental] Safari results
Details
@jgraham
Copy link
Contributor Author

jgraham commented May 18, 2019

Thanks for the review!

@gsnedders gsnedders deleted the element_timing_precondition branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.