Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a precondition to all the element timing tests #16898

Merged
merged 1 commit into from May 18, 2019
Merged

Add a precondition to all the element timing tests #16898

merged 1 commit into from May 18, 2019

Conversation

jgraham
Copy link
Contributor

@jgraham jgraham commented May 17, 2019

Since PerformanceObserver.observe doesn't have any way to signal an
unsupported type we end up just timing out all the tests in
implementations that doesn't support element timing. For efficiency
add a precondition to all the tests to check for the relevant API instead.

@jgraham
Add a precondition to all the element timing tests
175b09e 
Since PerformanceObserver.observe doesn't have any way to signal an
unsupported type we end up just timing out all the tests in
implementations that doesn't support element timing. For efficiency
add a precondition to all the tests to check for the relevant API instead.
@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@Hexcles Hexcles requested a review from npm1 May 17, 2019 19:55
npm1
npm1 approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@npm1 npm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We recently added PerformanceObserver.supportedEntryTypes. However since it's a new addition then a check like this might work better for now.

@jgraham jgraham merged commit 163424c into master May 18, 2019
@jgraham
Copy link
Contributor Author

jgraham commented May 18, 2019

Thanks for the review!

@gsnedders gsnedders deleted the element_timing_precondition branch September 10, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npm1 npm1 npm1 approved these changes

Assignees
No one assigned
Labels
element-timing status:needs-reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jgraham @wpt-pr-bot @npm1