Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address review comments that were mistakenly abandoned in #16452. #16899

Merged

Conversation

@LukeZielinski
Copy link
Contributor

LukeZielinski commented May 17, 2019

  • switch to synchronous test syntax
  • use assert_throws util function
- switch to synchronous test syntax
- use assert_throws util function
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot commented May 17, 2019

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

Copy link
Contributor

jugglinmike left a comment

Thanks!

@jugglinmike jugglinmike merged commit f4ea0fd into web-platform-tests:master May 17, 2019
10 checks passed
10 checks passed
Azure Pipelines Build #20190517.45 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@LukeZielinski LukeZielinski deleted the LukeZielinski:export-test-review branch Jun 14, 2019
marcoscaceres added a commit that referenced this pull request Jul 23, 2019
…6899)

- switch to synchronous test syntax
- use assert_throws util function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.