Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UserTimingL3] Throw error when global object is not Window object #16901

Merged
merged 1 commit into from May 22, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented May 17, 2019

The spec[1] says "If the global object is not a Window object, throw
a TypeError". We should check whether the global object is a window
object when converting a performance-timing name to timestamp. If
it is not, throw a Type Error.

[1] https://w3c.github.io/user-timing/#convert-a-name-to-a-timestamp

Bug: 953869
Change-Id: I188d810f2505a37f2cdfc823ce076cec96dd7839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613653
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662216}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1613653 branch 6 times, most recently from 6111f6c to ded783e May 17, 2019
The spec[1] says "If the global object is not a Window object, throw
a TypeError". We should check whether the global object is a window
object when converting a performance-timing name to timestamp. If
it is not, throw a Type Error.

[1] https://w3c.github.io/user-timing/#convert-a-name-to-a-timestamp

Bug: 953869
Change-Id: I188d810f2505a37f2cdfc823ce076cec96dd7839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613653
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662216}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1613653 branch from ded783e to 4f92c61 May 22, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 403bd67 into master May 22, 2019
13 checks passed
13 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
website-build-and-publish website-build-and-publish
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
Azure Pipelines Build #20190522.58 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1613653 branch May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.