Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring reference space naming/interfaces up to spec #16905

Merged
merged 1 commit into from May 22, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented May 17, 2019

eye-level -> local
floor-level -> local-floor
bounded -> bounded-floor
identity -> viewer

XRSession.viewerSpace is removed.

Bug: 963155, 961906, 953488
Change-Id: I5ab8b23ec14ffd5e2b272238b7fa11a29b11f09b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616525
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662072}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1616525 branch 6 times, most recently from c53294e to 78f3347 May 20, 2019
eye-level -> local
floor-level -> local-floor
bounded -> bounded-floor
identity -> viewer

XRSession.viewerSpace is removed.

Bug: 963155, 961906, 953488
Change-Id: I5ab8b23ec14ffd5e2b272238b7fa11a29b11f09b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616525
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662072}
@Hexcles
Copy link
Member

Hexcles commented May 22, 2019

Ignoring pre-existing Mojo flakiness.

@Hexcles Hexcles merged commit e4a1891 into master May 22, 2019
14 of 15 checks passed
14 of 15 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
manifest-build-and-tag manifest-build-and-tag
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
website-build-and-publish website-build-and-publish
Details
wpt.fyi - chrome[experimental] Chrome results
Details
Azure Pipelines Build #20190522.14 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@Hexcles Hexcles deleted the chromium-export-cl-1616525 branch May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.