[Navigation Timing] Replace TAO restrictions with same-origin ones #17412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 20, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1669355
branch
3 times, most recently
from
a55e3c1
to
ca9ee73
Compare
The NavigationTiming specification changed [1] to replace TAO based opt-in to get information about unloadStart, unloadEnd and redirectCount with same origin restrictions. Our implementation was not aligned with the old spec language, but isn't aligned with the new one either. This CL aligns the implementation with the new language. Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Bug: 977147 [1] w3c/navigation-timing#108 Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#671229}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1669355
branch
from
ca9ee73
to
c477597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NavigationTiming specification changed [1] to replace TAO based opt-in
to get information about unloadStart, unloadEnd and redirectCount with
same origin restrictions.
Our implementation was not aligned with the old spec language, but
isn't aligned with the new one either.
This CL aligns the implementation with the new language.
Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Bug: 977147
[1] w3c/navigation-timing#108
Change-Id: Ic4f3c7061e7b9a40f960f0bf26ef26823d5fe743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669355
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671229}