Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UserTimingL3] Checking against malformed performance.measure options. #17427

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jun 21, 2019

In the User Timing L3 spec
(https://w3c.github.io/user-timing/#measure-method), the
performance.measure function can take an options dictionary as its
second argument. If a non-empty dictionary is passed but neither of the
'start' nor 'end' members is present, a TypeError must be thrown.

This change adds checks for this case and raises the appropriate errors.
WPT coverage is also extended to check that user agents raise TypeErrors
as specified.

Change-Id: If47cf5803886cafb9dfab79c2cee1b6b572dbd3b
Bug: 982385
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669643
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686949}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [UserTimingL3] Checking against malformed performance.measure options [UserTimingL3] Checking against malformed performance.measure options. Jul 9, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1669643 branch 2 times, most recently from 936fb56 to f64844a Jul 9, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1669643 branch 2 times, most recently from 9d1ad35 to 7fc4299 Aug 14, 2019
In the User Timing L3 spec
(https://w3c.github.io/user-timing/#measure-method), the
performance.measure function can take an options dictionary as its
second argument. If a non-empty dictionary is passed but neither of the
'start' nor 'end' members is present, a TypeError must be thrown.

This change adds checks for this case and raises the appropriate errors.
WPT coverage is also extended to check that user agents raise TypeErrors
as specified.

Change-Id: If47cf5803886cafb9dfab79c2cee1b6b572dbd3b
Bug: 982385
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669643
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686949}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1669643 branch from 7fc4299 to 56d035c Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 91adbef into master Aug 14, 2019
9 checks passed
9 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
Azure Pipelines Build #20190814.160 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1669643 branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.