Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idlharness] Check exposure set after inheritance #17560

Closed
wants to merge 2 commits into from
Closed

Conversation

@lukebjerring
Copy link
Contributor

lukebjerring commented Jun 27, 2019

Fixes #17551

Assert that the exposure set for the inheritor is a subset of the base.

@lukebjerring
Copy link
Contributor Author

lukebjerring commented Jul 25, 2019

Part of #8053

@lukebjerring lukebjerring added this to Done in Improve idlharness.js via automation Aug 15, 2019
@lukebjerring lukebjerring reopened this Aug 15, 2019
Improve idlharness.js automation moved this from Done to In progress Aug 15, 2019
@foolip
Copy link
Member

foolip commented Oct 23, 2019

I'll rebase this to see what effect it'd have now.

@foolip foolip force-pushed the exposed branch from c57f737 to 1e542e1 Oct 23, 2019
@foolip
Copy link
Member

foolip commented Oct 23, 2019

Closing in favor of the webidl2.js validation approach: #17551 (comment)

@foolip foolip closed this Oct 23, 2019
Improve idlharness.js automation moved this from In progress to Done Oct 23, 2019
@foolip foolip deleted the exposed branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.