Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement RTCPeerConnection.onicecandidateerror and add web-platform-test #17642
Conversation
|
Already reviewed downstream. |
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-1607800
branch
from
5c3d286
to
ef74d9c
…test Spec: https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-onicecandidateerror Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/fs-Y4awdYj0 Bug: webrtc:3098 Change-Id: I9c4a3ec75050e85f2a13b896f580bc16206ca2c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607800 Commit-Queue: Eldar Rello <elrello@microsoft.com> Reviewed-by: Qingsi Wang <qingsi@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#676359}
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-1607800
branch
from
ef74d9c
to
09e7054
chromium-wpt-export-bot
merged commit ee75c68
into
master
15 checks passed
15 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
chromium-wpt-export-bot commentedJul 4, 2019
•
edited
Spec:
https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-onicecandidateerror
Intent:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/fs-Y4awdYj0
Bug: webrtc:3098
Change-Id: I9c4a3ec75050e85f2a13b896f580bc16206ca2c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607800
Commit-Queue: Eldar Rello <elrello@microsoft.com>
Reviewed-by: Qingsi Wang <qingsi@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676359}