Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1305732] part6 : modify wpts. #17713

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Jul 9, 2019

In this patch, we do the following changes.

  1. using Ahem and using it as recommanded font size and line height.
  2. reduce the cue text length in align_center_position_lt_50.vtt and align_center_position_gt_50.vtt in order to prevent text wrapping to multiple lines
  3. wrapping to mulitple lines would be tested in align_center_position_lt_50_size_gt_maximum_size.html and align_center_position_gt_50_size_gt_maximum_size-ref.html

Differential Revision: https://phabricator.services.mozilla.com/D35695

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1305732
gecko-commit: 81c49925fdb4e1b71a3098acb5dd873dc4efab6e
gecko-integration-branch: central
gecko-reviewers: heycam

In this patch, we do the following changes.

1. using Ahem and using it as recommanded font size and line height.
2. reduce the cue text length in `align_center_position_lt_50.vtt` and `align_center_position_gt_50.vtt` in order to prevent text wrapping to multiple lines
3. wrapping to mulitple lines would be tested in `align_center_position_lt_50_size_gt_maximum_size.html` and `align_center_position_gt_50_size_gt_maximum_size-ref.html`

Differential Revision: https://phabricator.services.mozilla.com/D35695

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1305732
gecko-commit: 81c49925fdb4e1b71a3098acb5dd873dc4efab6e
gecko-integration-branch: central
gecko-reviewers: heycam
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@jgraham jgraham closed this Jul 11, 2019
@jgraham jgraham reopened this Jul 11, 2019
@jgraham

This comment has been minimized.

Copy link
Contributor

jgraham commented Jul 24, 2019

Failure is in Firefox only:
Failure is

Unstable results

Test Subtest Results Messages
/webvtt/rendering/cues-with-video/processing-model/align_center_position_gt_50_size_gt_maximum_size.html FAIL: 1/10, PASS: 9/10
/webvtt/rendering/cues-with-video/processing-model/align_center_position_lt_50_size_gt_maximum_size.html FAIL: 1/10, PASS: 9/10

Merging anyway since this is already on m-c.

@jgraham jgraham merged commit 28cb96c into master Jul 24, 2019
7 of 13 checks passed
7 of 13 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
Taskcluster (pull_request) TaskGroup: failure
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190711.49 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
upstream/gecko Landed on mozilla-central
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1305732 branch Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.