Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change height and width of set.py tests to be larger than min for chrome #17772

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@julianrkung
Copy link
Contributor

julianrkung commented Jul 10, 2019

Chrome's webdriver was failing test_width_height_floats, test_restore_from_minimized, and test_restore_from_maximized because the proposed width change (<=500 pixels) was smaller than chrome's set minimum browser size. Changed all such values in the above tests (both height and width as a precaution) to more moderate values that shouldn't conflict with minimum or maximum browser size for any browser.

Copy link
Member

andreastt left a comment

@andreastt andreastt merged commit 36acf7a into web-platform-tests:master Jul 11, 2019
10 checks passed
10 checks passed
Azure Pipelines Build #20190710.120 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@whimboo

This comment has been minimized.

Copy link
Contributor

whimboo commented Jul 23, 2019

@julianrkung, have you seen the last comment from @andreastt? Do we have another PR for that yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.