Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UserTimingL3] Fix crash: create mark in worker #17773

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jul 10, 2019

Currently, the renderer crashes when creating mark entry in worker.
The crash is because PerformanceMark::Create() return nullptr without
setting exception_state. The caller of the function assumes that
no exception indicates the PerformanceMark entry exists. Thus, when the
entry is visited, the crash occurs.

There is another bug hidden in this issue. Currently, when
window-performance is not found, Create() returns nullptr directly. It
should instead also check whether worker-performance exist.

This CL fix these issues.

To verify the change, the CL also changes the related web tests from
*.html to *.any.js, which enables these tests in worker's context.

Bug: 981982

Change-Id: Ia20ce1c194e4db2810ff3f1c52070e5970951600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696085
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676484}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1696085 branch 3 times, most recently from 35f93bb to f3fc388 Jul 10, 2019
Currently, the renderer crashes when creating mark entry in worker.
The crash is because PerformanceMark::Create() return nullptr without
setting exception_state. The caller of the function assumes that
no exception indicates the PerformanceMark entry exists. Thus, when the
entry is visited, the crash occurs.

There is another bug hidden in this issue. Currently, when
window-performance is not found, Create() returns nullptr directly. It
should instead also check whether worker-performance exist.

This CL fix these issues.

To verify the change, the CL also changes the related web tests from
*.html to *.any.js, which enables these tests in worker's context.

Bug: 981982

Change-Id: Ia20ce1c194e4db2810ff3f1c52070e5970951600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696085
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676484}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1696085 branch from f3fc388 to cd05ec1 Jul 11, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 1333238 into master Jul 11, 2019
15 checks passed
15 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190711.84 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1696085 branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.