Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action option string to be passed to toast showToast() #17774

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jul 10, 2019

This partially implements the action option for showToast(),
as outlined in the explainer at
https://github.com/jackbsteinberg/std-toast/blob/32237007b068d690f39002d364367f3c097f1a97/README.md#showtoastmessage-options.
For now it only handles the string or undefined cases;
the Element case will be handled in a follow-up CL once the action setter is implemented.

BUG=972945

Change-Id: I82556801a6586c89cd506669f935488e049c47c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684466
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676168}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1684466 branch from 32548e8 to 4c734b2 Jul 10, 2019
This partially implements the action option for showToast(),
as outlined in the explainer at
https://github.com/jackbsteinberg/std-toast/blob/32237007b068d690f39002d364367f3c097f1a97/README.md#showtoastmessage-options.
For now it only handles the string or undefined cases;
the Element case will be handled in a follow-up CL once the action setter is implemented.

BUG=972945

Change-Id: I82556801a6586c89cd506669f935488e049c47c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684466
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676168}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1684466 branch from 4c734b2 to 24e5086 Jul 10, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 996e93b into master Jul 11, 2019
15 checks passed
15 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
Azure Pipelines Build #20190710.161 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1684466 branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.