Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially fix calc() length unit handling in media queries #17775

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jul 10, 2019

When a calc() length is passed to media queries, the current code
assumes that there's always a DoubleValue(), and the unit type matches
TypeWithCalcResolved(), which is incorrect.

This patch partially fixes the issue when the calc expression can be
resolved without type conversion. Handling type conversion is more
complicated and hence left broken by this patch (as it's already broken).

Bug: 982542
Change-Id: I258b3d1aeec69fb65fbadd86981e97974239289b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696191
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676452}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

When a calc() length is passed to media queries, the current code
assumes that there's always a DoubleValue(), and the unit type matches
TypeWithCalcResolved(), which is incorrect.

This patch partially fixes the issue when the calc expression can be
resolved without type conversion. Handling type conversion is more
complicated and hence left broken by this patch (as it's already broken).

Bug: 982542
Change-Id: I258b3d1aeec69fb65fbadd86981e97974239289b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696191
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676452}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1696191 branch from ab4c4b5 to 56bd232 Jul 11, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 14acac0 into master Jul 11, 2019
15 checks passed
15 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
wpt.fyi - chrome[experimental] Chrome results
Details
Azure Pipelines Build #20190711.76 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1696191 branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.