Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-transforms] Avoid using assert_own_property on testing style properties. #17778

Merged

Conversation

@BorisChiou
Copy link
Member

BorisChiou commented Jul 10, 2019

These assert_own_property tests cause these CSS tests to fail on Firefox only, and I think these properties are not supposted to be own properties, so use a similar way as #16892, to test the existence of these properties.

cc @emilio

@wpt-pr-bot wpt-pr-bot requested review from dbaron, dirkschulze, grorg and plinss Jul 10, 2019
@BorisChiou BorisChiou changed the title [css-transform] Avoid using assert_own_property on testing style properties. [css-transforms] Avoid using assert_own_property on testing style properties. Jul 10, 2019
These `assert_own_property` tests cause these CSS tests to fail on Firefox
only, and I think these properties are not supposted to be own properties,
so use a similar way as #16892,
to test the existence of these properties.
@BorisChiou BorisChiou force-pushed the BorisChiou:transform/property_check branch from 899bef6 to b54697e Jul 10, 2019
@emilio
emilio approved these changes Jul 11, 2019
@emilio emilio merged commit 47543ee into web-platform-tests:master Jul 11, 2019
10 checks passed
10 checks passed
Azure Pipelines Build #20190710.159 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
natechapin added a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
…eb-platform-tests#17778)

These `assert_own_property` tests cause these CSS tests to fail on Firefox
only, and I think these properties are not supposted to be own properties,
so use a similar way as web-platform-tests#16892,
to test the existence of these properties.
@BorisChiou BorisChiou deleted the BorisChiou:transform/property_check branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.