Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS property 'tab-size' should take 'number' instead of 'integer'. #17779

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jul 11, 2019

According to https://drafts.csswg.org/css-text-3/#tab-size-property,
let 'tab-size' take css 'number' value, not css 'integer' value.

Bug: 974090
Change-Id: Idb235eacde59f5bae1ab7fb814425fae4b93a227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689165
Commit-Queue: Joonghun Park <pjh0718@gmail.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676741}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1689165 branch 4 times, most recently from a8b2069 to fd85f6c Jul 11, 2019
According to https://drafts.csswg.org/css-text-3/#tab-size-property,
let 'tab-size' take css 'number' value, not css 'integer' value.

Bug: 974090
Change-Id: Idb235eacde59f5bae1ab7fb814425fae4b93a227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689165
Commit-Queue: Joonghun Park <pjh0718@gmail.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676741}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1689165 branch from fd85f6c to 52bffff Jul 12, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 01669b3 into master Jul 12, 2019
9 of 15 checks passed
9 of 15 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190712.16 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1689165 branch Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.