Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create toast action setter #17780

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jul 11, 2019

Additionally, this CL adds support for passing Elements
as action in showToast, using the action setter.
This change is the latest in a series of changes implementing
new behavior added to the toast explainer in PR #43
jackbsteinberg/std-toast#43.

Bug: 972945
Change-Id: I46004883cb3b794981029aa02369918dd0077391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686786
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676482}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1686786 branch from 38a917a to 36334a0 Jul 11, 2019
Additionally, this CL adds support for passing Elements
as action in showToast, using the action setter.
This change is the latest in a series of changes implementing
new behavior added to the toast explainer in PR #43
jackbsteinberg/std-toast#43.

Bug: 972945
Change-Id: I46004883cb3b794981029aa02369918dd0077391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686786
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676482}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1686786 branch from 36334a0 to f7ffd40 Jul 11, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 11051ca into master Jul 11, 2019
13 of 15 checks passed
13 of 15 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
Azure Pipelines Build #20190711.83 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1686786 branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.