Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manifest] Fix GitHasher when test_root!=repo_root #17783

Closed
wants to merge 1 commit into from

Conversation

@Hexcles
Copy link
Member

Hexcles commented Jul 11, 2019

Fixes #17749 by using git diff --name-only --relative instead of git status. The --relative flag is key: it limits the changes to the
current directory and also outputs relative paths. CWD is already set to
tests_root by utils.git.

Fixes #17749 by using `git diff --name-only --relative` instead of `git
status`. The `--relative` flag is key: it limits the changes to the
current directory and also outputs relative paths. CWD is already set to
tests_root by utils.git.
@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Jul 11, 2019

I fixed this a month ago in https://bugzilla.mozilla.org/show_bug.cgi?id=1558363; any reason why that never got exported @jgraham?

@jgraham

This comment has been minimized.

Copy link
Contributor

jgraham commented Jul 11, 2019

I'm investigating (but the service is currently being redeployed).

@Hexcles

This comment has been minimized.

Copy link
Member Author

Hexcles commented Jul 11, 2019

Dropped in favour of #17785 .

@Hexcles Hexcles closed this Jul 11, 2019
@Hexcles Hexcles deleted the fix-githasher branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.