Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Mozilla CSS tests as of 2019-07-11 #17784

Conversation

@dbaron
Copy link
Member

dbaron commented Jul 11, 2019

Sync Mozilla CSS tests as of https://hg.mozilla.org/mozilla-central/rev/a39b925a26ade6f6d05c51dde62764b149043a00 .

This contains changes from one bug:

@dbaron dbaron self-assigned this Jul 11, 2019
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@dbaron dbaron closed this Jul 11, 2019
@dbaron dbaron reopened this Jul 11, 2019
@dbaron dbaron closed this Jul 11, 2019
@dbaron dbaron reopened this Jul 11, 2019
@dbaron dbaron closed this Jul 11, 2019
@dbaron dbaron reopened this Jul 11, 2019
@dbaron

This comment has been minimized.

Copy link
Member Author

dbaron commented Jul 11, 2019

I'm unable to merge this because the Firefox stability tests are failing. I think bug 1381855 describes the underlying problem, that the WPT reftest harness doesn't wait for objects or embeds to load. I'm not aware of any bug about fixing that.

@BorisChiou

This comment has been minimized.

Copy link
Member

BorisChiou commented Jul 11, 2019

OK. I see. I used a script to update all files, including the disabled ones, so could we manually merge this? I guess this issue sometimes happens in wpt.

cc @jgraham

@dbaron

This comment has been minimized.

Copy link
Member Author

dbaron commented Jul 11, 2019

I filed bug 1565384 on the underlying stability problem.

I'm not sure what you mean by "update all files" or "manually merge".

@BorisChiou

This comment has been minimized.

Copy link
Member

BorisChiou commented Jul 11, 2019

Sorry for the vague word, "manually merge". For wpt, I thought someone could "force" merge the PR if the stability issue is not related to this PR. Thanks for filing this bug.

@sideshowbarker sideshowbarker merged commit 1f951fe into web-platform-tests:master Jul 12, 2019
9 of 10 checks passed
9 of 10 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
Azure Pipelines Build #20190711.111 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.