Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1558363] Fix WPT manifest updates when within a git tree #17785

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Jul 11, 2019

This has been broken since bug 1545629 landed, when we started using
git to (quickly) get hashes of unchanged files. Unfortunately, the
logic for finding changed files only worked when the test root was the
root of the git repository.

Differential Revision: https://phabricator.services.mozilla.com/D34702

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1558363
gecko-commit: b975b4c1dfaebedabc4a09296b90303c7d5381e3
gecko-integration-branch: central
gecko-reviewers: jgraham

This has been broken since bug 1545629 landed, when we started using
git to (quickly) get hashes of unchanged files. Unfortunately, the
logic for finding changed files only worked when the test root was the
root of the git repository.

Differential Revision: https://phabricator.services.mozilla.com/D34702

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1558363
gecko-commit: b975b4c1dfaebedabc4a09296b90303c7d5381e3
gecko-integration-branch: central
gecko-reviewers: jgraham
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@Hexcles

This comment has been minimized.

Copy link
Member

Hexcles commented Jul 11, 2019

Fixes #17749 . (GitHub probably does not honour magic keywords in comments, but I'm not sure if it's safe to edit the PR description directly.)

Copy link
Member

Hexcles left a comment

LGTM. This also replaces #17783 .

tools/manifest/vcs.py Show resolved Hide resolved
@moz-wptsync-bot moz-wptsync-bot merged commit 3fb0150 into master Jul 11, 2019
19 checks passed
19 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
Azure Pipelines Build #20190711.91 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows Python 3) tools/ unittests: Windows Python 3 succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
upstream/gecko Landed on mozilla-central
Details
wpt.fyi - safari[experimental] Safari results
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1558363 branch Jul 11, 2019
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 11, 2019
Bug: web-platform-tests/wpt#17749
Fix: web-platform-tests/wpt#17785

This bug would prevent the manifest from updating when local changes are
made in the working tree, which severely affects the daily workflow of
Blink engineers (bots are not affected).

Change-Id: Icf080553a8c8626c10d7973eb21ec4214c889d16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697371
Reviewed-by: Luke Z <lpz@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676570}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.