Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1563278] Specify font-family and font-size on the same element in web-platform-test contain-paint-008.html. #17786

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Jul 11, 2019

This patch corrects a likely-inadvertent difference between the CSS in this
testcase vs. its reference case.

This patch fixes a Windows & MacOS off-by-1px spurious failure in this test,
which was probably due to having text whose font-metrics differ from its
line-box (in the testcase) vs. agree with its line-box (in the reference).

While we're here, this patch also adjusts the code-comment in the testcase
to avoid implying that Firefox unconditionally lacks support for containment.
(And to fix a minor grammatical typo, "not need" --> "no need".)

Differential Revision: https://phabricator.services.mozilla.com/D37494

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1563278
gecko-commit: bbcd2af40409fad89375fcaabc5b83d9ae99e99e
gecko-integration-branch: central
gecko-reviewers: TYLin

…-test contain-paint-008.html.

This patch corrects a likely-inadvertent difference between the CSS in this
testcase vs. its reference case.

This patch fixes a Windows & MacOS off-by-1px spurious failure in this test,
which was probably due to having text whose font-metrics differ from its
line-box (in the testcase) vs. agree with its line-box (in the reference).

While we're here, this patch also adjusts the code-comment in the testcase
to avoid implying that Firefox unconditionally lacks support for containment.
(And to fix a minor grammatical typo, "not need" --> "no need".)

Differential Revision: https://phabricator.services.mozilla.com/D37494

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1563278
gecko-commit: bbcd2af40409fad89375fcaabc5b83d9ae99e99e
gecko-integration-branch: central
gecko-reviewers: TYLin
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@moz-wptsync-bot moz-wptsync-bot merged commit 4ab7163 into master Jul 11, 2019
13 checks passed
13 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
Azure Pipelines Build #20190711.93 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
upstream/gecko Landed on mozilla-central
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1563278 branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.