Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1562701] Move the reframing logic of <details> element into WipeContainingBlock. #17788

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Jul 11, 2019

We don't need to treat a details frame as if it has multiple content
insertion points in order to reframe it. We can just put the logic into
WipeContainingBlock().

The reftests layout/reftests/details-summary/dynamic-add-*.html also
cover adding

into a
in various situations.

Differential Revision: https://phabricator.services.mozilla.com/D36529

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562701
gecko-commit: 10faf756124c232c9b460afc72168ea54fa6ab03
gecko-integration-branch: central
gecko-reviewers: dbaron

We don't need to treat a details frame as if it has multiple content
insertion points in order to reframe it. We can just put the logic into
WipeContainingBlock().

The reftests layout/reftests/details-summary/dynamic-add-*.html also
cover adding <summary> into a <details> in various situations.

Differential Revision: https://phabricator.services.mozilla.com/D36529

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562701
gecko-commit: 10faf756124c232c9b460afc72168ea54fa6ab03
gecko-integration-branch: central
gecko-reviewers: dbaron
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@moz-wptsync-bot moz-wptsync-bot merged commit 6fca6d4 into master Jul 11, 2019
11 of 13 checks passed
11 of 13 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
Azure Pipelines Build #20190711.97 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
upstream/gecko Landed on mozilla-central
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1562701 branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.