Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1528061] wptrunner sends non-blocking message when handling fonts on Windows. #17793

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Jul 11, 2019

This changes the wptrunner to use SendNotifyMessageW instead of SendMessageW
when installing and removing fonts on Windows. The difference between these calls
is that SendNotifyMessageW will not block on each window processing the message
while SendMessageW will. This addresses an issue where the wptrunner would stall
if a window was not processing the font added or removed message.

Differential Revision: https://phabricator.services.mozilla.com/D37617

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1528061
gecko-commit: cde6d92a2230097c57233c6fa215e746ea672c0e
gecko-integration-branch: autoland
gecko-reviewers: jgraham

This changes the wptrunner to use SendNotifyMessageW instead of SendMessageW
when installing and removing fonts on Windows. The difference between these calls
is that SendNotifyMessageW will not block on each window processing the message
while SendMessageW will. This addresses an issue where the wptrunner would stall
if a window was not processing the font added or removed message.

Differential Revision: https://phabricator.services.mozilla.com/D37617

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1528061
gecko-commit: cde6d92a2230097c57233c6fa215e746ea672c0e
gecko-integration-branch: autoland
gecko-reviewers: jgraham
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@moz-wptsync-bot moz-wptsync-bot merged commit a3d0b05 into master Jul 12, 2019
18 of 19 checks passed
18 of 19 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
upstream/gecko Landed on mozilla-central
Details
Azure Pipelines Build #20190711.113 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (tools/ unittests: Windows Python 3) tools/ unittests: Windows Python 3 succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - safari[experimental] Safari results
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1528061 branch Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.