Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[Gecko Bug 1528061] wptrunner sends non-blocking message when handling fonts on Windows. #17793
Conversation
This changes the wptrunner to use SendNotifyMessageW instead of SendMessageW when installing and removing fonts on Windows. The difference between these calls is that SendNotifyMessageW will not block on each window processing the message while SendMessageW will. This addresses an issue where the wptrunner would stall if a window was not processing the font added or removed message. Differential Revision: https://phabricator.services.mozilla.com/D37617 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1528061 gecko-commit: cde6d92a2230097c57233c6fa215e746ea672c0e gecko-integration-branch: autoland gecko-reviewers: jgraham
|
Already reviewed downstream. |
moz-wptsync-bot
merged commit a3d0b05
into
master
18 of 19 checks passed
18 of 19 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (tools/ unittests: Windows Python 3)
tools/ unittests: Windows Python 3 succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows)
tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS)
tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-wptsync-bot commentedJul 11, 2019
This changes the wptrunner to use SendNotifyMessageW instead of SendMessageW
when installing and removing fonts on Windows. The difference between these calls
is that SendNotifyMessageW will not block on each window processing the message
while SendMessageW will. This addresses an issue where the wptrunner would stall
if a window was not processing the font added or removed message.
Differential Revision: https://phabricator.services.mozilla.com/D37617
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1528061
gecko-commit: cde6d92a2230097c57233c6fa215e746ea672c0e
gecko-integration-branch: autoland
gecko-reviewers: jgraham