Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Fix when adding a hyphen causes the line to overflow #17803

Merged
merged 1 commit into from Jul 14, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jul 12, 2019

When adding a hyphen causes the line to overflow, this patch
retries another break opportunity with the reeuced available
width instead of the line to overflow.

Bug: 982729
Change-Id: I8e7e56fe68cdfb101ebfedd3a43c062c97a56e81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699942
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677216}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1699942 branch from 37a9cd2 to d41cc65 Jul 14, 2019
When adding a hyphen causes the line to overflow, this patch
retries another break opportunity with the reeuced available
width instead of the line to overflow.

Bug: 982729
Change-Id: I8e7e56fe68cdfb101ebfedd3a43c062c97a56e81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699942
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677216}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1699942 branch from d41cc65 to b285a8e Jul 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 719721f into master Jul 14, 2019
12 of 15 checks passed
12 of 15 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
wpt.fyi - chrome[experimental] Chrome results
Details
Azure Pipelines Build #20190714.9 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1699942 branch Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.