Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed expected change event from assert_events_equal in test_contenteditable #17813


Copy link

@julianrkung julianrkung commented Jul 12, 2019

The definition of change event is as follows:

The change event is fired for <input>, <select>, and <textarea> elements when an alteration to the element's value is committed by the user.

Therefore, since clear is occurring on a <p> tag, no change event should fire. This changelist makes this correction.

@andreastt andreastt merged commit 09f6396 into web-platform-tests:master Jul 15, 2019
10 checks passed
10 checks passed - firefox[experimental] Firefox results
Azure Pipelines Build #20190712.78 succeeded
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Azure Pipelines ( hook: safari-preview-affected-tests) hook: safari-preview-affected-tests succeeded
Azure Pipelines ( hook: safari-preview-affected-tests-without-changes) hook: safari-preview-affected-tests-without-changes succeeded
Taskcluster (pull_request) TaskGroup: success
Details - chrome[experimental] Chrome results
Details - safari[experimental] Safari results
natechapin added a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
…nteditable (web-platform-tests#17813)

The change event does not fire on contenteditable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants