Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webxr-test-api method names to floorOrigin #17814

Merged
merged 1 commit into from Jul 13, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jul 12, 2019

Per feedback on the spec and updates to the comments about what an
origin actually is, the API method names and dictionary values were
updated from localToFloorTransform to the more accurate floorOrigin. The
current usage of these items actually matches the new name and therefore
were previously improperly named.

Bug: 979316
Change-Id: I9deedf9cf25e804135251b8e20a30d89f0eb6276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700176
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677129}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

Per feedback on the spec and updates to the comments about what an
origin actually is, the API method names and dictionary values were
updated from localToFloorTransform to the more accurate floorOrigin. The
current usage of these items actually matches the new name and therefore
were previously improperly named.

Bug: 979316
Change-Id: I9deedf9cf25e804135251b8e20a30d89f0eb6276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700176
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677129}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1700176 branch from 7e2d803 to 67d5a0b Jul 13, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 897fc65 into master Jul 13, 2019
14 of 16 checks passed
14 of 16 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
Azure Pipelines Build #20190713.6 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1700176 branch Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.