Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1565690] When inferring an aspect ratio from an image's width and height attribute, only honor it if we don't have the real image aspect-ratio. #17815

Merged
merged 1 commit into from Jul 13, 2019

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Jul 12, 2019

Since people like to get wrong attribute values on their images (see the
regressions from bug 1547231).

Differential Revision: https://phabricator.services.mozilla.com/D37936

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1565690
gecko-commit: aa0016d9f9f827f86bb82d632998b2d5706fe851
gecko-integration-branch: autoland
gecko-reviewers: dholbert

…bute, only honor it if we don't have the real image aspect-ratio.

Since people like to get wrong attribute values on their images (see the
regressions from bug 1547231).

Differential Revision: https://phabricator.services.mozilla.com/D37936

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1565690
gecko-commit: aa0016d9f9f827f86bb82d632998b2d5706fe851
gecko-integration-branch: autoland
gecko-reviewers: dholbert
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@moz-wptsync-bot moz-wptsync-bot merged commit 79688a3 into master Jul 13, 2019
9 of 13 checks passed
9 of 13 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
upstream/gecko Landed on mozilla-central
Details
wpt.fyi - firefox[experimental] Firefox results
Details
Azure Pipelines Build #20190712.83 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - safari[experimental] Safari results
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1565690 branch Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.