Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1562086] Add percentage for opacity (i.e. <alpha-value>). #17817

Merged
merged 1 commit into from Jul 13, 2019

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Jul 12, 2019

The following properties accept [1], which is
" | ", so we update the parser, spec links, and
their web-platform-tests.

  1. opacity
  2. flood-opacity
  3. fill-opacity
  4. stroke-opacity
  5. stop-opacity
  6. -moz-window-opacity

Besides, shape-image-threshold [2] still only accepts , so we need
to support a different version of Opacity::parse().

[1] https://drafts.csswg.org/css-color/#typedef-alpha-value
[2] https://drafts.csswg.org/css-shapes/#shape-image-threshold-property

Differential Revision: https://phabricator.services.mozilla.com/D37493

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562086
gecko-commit: abe58536c427f4a810df1274a6069b8a4832bcf2
gecko-integration-branch: autoland
gecko-reviewers: emilio

The following properties accept <alpha-value> [1], which is
"<number> | <percentage>", so we update the parser, spec links, and
their web-platform-tests.
1. opacity
2. flood-opacity
3. fill-opacity
4. stroke-opacity
5. stop-opacity
6. -moz-window-opacity

Besides, shape-image-threshold [2] still only accepts <number>, so we need
to support a different version of `Opacity::parse()`.

[1] https://drafts.csswg.org/css-color/#typedef-alpha-value
[2] https://drafts.csswg.org/css-shapes/#shape-image-threshold-property

Differential Revision: https://phabricator.services.mozilla.com/D37493

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562086
gecko-commit: abe58536c427f4a810df1274a6069b8a4832bcf2
gecko-integration-branch: autoland
gecko-reviewers: emilio
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@moz-wptsync-bot moz-wptsync-bot merged commit 1b1a487 into master Jul 13, 2019
12 of 13 checks passed
12 of 13 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
upstream/gecko Landed on mozilla-central
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190712.92 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1562086 branch Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.