Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OT-PW] Animation integration with new CC impl #17938

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jul 19, 2019

This CL is for Off-thread PaintWorklet animation
integration described in this design doc:
https://docs.google.com/document/d/1a7gO6cBxsJhn53akuJuieUiXvB74vvEmFDyKww8NKdw/edit#

Right now this CL handles composited custom property animations
only, handling native properties should be simpler. Also,
right now we only support custom properties that represent
numerical values.

Here is a summary of the main changes:
A new class AnimatedPaintWorkletTracker is created and LTHI
keeps an instance of it. The new class maintains a hashmap
such that when CC animation ticks, LTHI is able to update the
custom property values for corresponding PaintWorkletInput. And
also that when LTHI needs to dispatch paint job to the worklet
thread, it is able to identify which paint worklets are dirty.

Other changes are mostly plumbing needs associated with the
above changes.

Bug: 956650
Change-Id: If27d6d21cf8fab31e0a2719d81b61cae3d4f3268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614120
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687049}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1614120 branch 9 times, most recently from e1e8404 to be8f8c8 Jul 22, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1614120 branch 5 times, most recently from 95596c0 to 8dadb88 Jul 30, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1614120 branch 10 times, most recently from faa3e21 to b96629e Aug 7, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1614120 branch 2 times, most recently from e25ed05 to 238c82b Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1614120 branch 3 times, most recently from 8ed8622 to b4e7a65 Aug 14, 2019
This CL is for Off-thread PaintWorklet animation
integration described in this design doc:
https://docs.google.com/document/d/1a7gO6cBxsJhn53akuJuieUiXvB74vvEmFDyKww8NKdw/edit#

Right now this CL handles composited custom property animations
only, handling native properties should be simpler. Also,
right now we only support custom properties that represent
numerical values.

Here is a summary of the main changes:
A new class AnimatedPaintWorkletTracker is created and LTHI
keeps an instance of it. The new class maintains a hashmap
such that when CC animation ticks, LTHI is able to update the
custom property values for corresponding PaintWorkletInput. And
also that when LTHI needs to dispatch paint job to the worklet
thread, it is able to identify which paint worklets are dirty.

Other changes are mostly plumbing needs associated with the
above changes.

Bug: 956650
Change-Id: If27d6d21cf8fab31e0a2719d81b61cae3d4f3268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614120
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687049}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1614120 branch from b4e7a65 to fbedfc9 Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 31d0510 into master Aug 14, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190814.192 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1614120 branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.