Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize valid IDL buffer source primitive types #18003

Closed
wants to merge 1 commit into from

Conversation

@lukebjerring
Copy link
Contributor

lukebjerring commented Jul 23, 2019

Buffer source types defined here:
https://heycam.github.io/webidl/#idl-buffer-source-types

These types are never explicitly mentioned in IDL, so will not be pulled in as dependencies. As a result, we see Unrecognized type Uint8ClampedArray and similar when these types are referenced.

This PR simply recognizes those types and makes a simple typeof x === 'object' assertion.

Copy link
Contributor

foolip left a comment

Can you add some tests for this so it doesn't break with refactoring?

@lukebjerring lukebjerring force-pushed the buffersource branch from cf337b7 to faf4d75 Oct 10, 2019
@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Oct 10, 2019

Closing this as redundant; seems to have no meaningful effect on the results.

@lukebjerring lukebjerring added this to Done in Improve idlharness.js via automation Oct 10, 2019
@foolip foolip deleted the buffersource branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.