Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite color values on the worklet thread #18013

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jul 23, 2019

Follow up to:
https://chromium-review.googlesource.com/c/chromium/src/+/1614120
(Allows number values to be composited on the worklet thread)
--and--
https://chromium-review.googlesource.com/c/chromium/src/+/1698667
(Allows creation of keyframe model for color values on compositor)

This CL adds similar functionality as that used for number types to update
color values on the compositor. New classes CrossThreadColorValue and
CSSUnsupportedColorValue were created for CSSPaintValue::GetImage to identify
color valued custom properties as compositable.

Bug: 883721
Change-Id: Ib8c26e5c6c6077b21288de3156fa35cc6e02435d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713747
Commit-Queue: Adam Raine <asraine@google.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687702}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1713747 branch 3 times, most recently from cab46bb to 0812d2c Jul 24, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1713747 branch 4 times, most recently from 2656ad4 to 0a085d4 Aug 1, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1713747 branch 9 times, most recently from 039c082 to 805e1d7 Aug 9, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1713747 branch from 805e1d7 to 7105552 Aug 16, 2019
Follow up to:
https://chromium-review.googlesource.com/c/chromium/src/+/1614120
(Allows number values to be composited on the worklet thread)
--and--
https://chromium-review.googlesource.com/c/chromium/src/+/1698667
(Allows creation of keyframe model for color values on compositor)

This CL adds similar functionality as that used for number types to update
color values on the compositor.  New classes CrossThreadColorValue and
CSSUnsupportedColorValue were created for CSSPaintValue::GetImage to identify
color valued custom properties as compositable.

Bug: 883721
Change-Id: Ib8c26e5c6c6077b21288de3156fa35cc6e02435d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713747
Commit-Queue: Adam Raine <asraine@google.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687702}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 7c42039 into master Aug 16, 2019
13 checks passed
13 checks passed
update-pr-preview
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190816.186 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1713747 branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.