Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Import Maps] Update resolving tests from upstream #18264

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 3, 2019

This CL imports more tests from upstream:

The current test failures are added as -expected.txt, and will be
fixed in the future when import map functionalities are implemented or fixed.

Bug: 990561
Change-Id: I087df82355513584a0cf1891da648dd2155f53c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734024
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686701}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1734024 branch 2 times, most recently from 81b5f12 to c05ac61 Aug 13, 2019
This CL imports more tests from upstream:

- Test files from
  https://github.com/WICG/import-maps/tree/master/reference-implementation/__tests__
  are imported to import-maps/imported/resources/.
- Generated test HTMLs are placed in import-maps/imported/.
- To support more tests, the glue code in resolving.tentative.html
  is moved into `jest-test-helper.js` and extended to support new tests.

The current test failures are added as -expected.txt, and will be
fixed in the future when import map functionalities are implemented or fixed.

Bug: 990561
Change-Id: I087df82355513584a0cf1891da648dd2155f53c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734024
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686701}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1734024 branch from c05ac61 to 826defb Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a29f9a0 into master Aug 14, 2019
14 of 16 checks passed
14 of 16 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190814.11 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1734024 branch Aug 14, 2019
@guest271314
Copy link
Contributor

guest271314 commented Aug 14, 2019

Appears GitHub is stripping "__" from end of the URL.

@guest271314
Copy link
Contributor

guest271314 commented Aug 14, 2019

Using []() for the link resolves to correct URL import-maps/reference-implementation/tests/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.