Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webnfc] Enable wpt tests with mock nfc implementation #18290

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 6, 2019

This CL enables all failure tests from wpt/web-nfc/(except the idlharness tests) with mock NFC
implementation, which automates all the manual tests at the same time.

Merge NFCWriter#push() relevant tests into one file: NFCWriter_push.https.html

Merge NFCReader relevant tests into two separate files: NFCReader.https.html and
NFCReader_options.https.html

BUG=520391

Change-Id: Iefc61b618bebcdc198dc4a2470350480b2cc2cd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737993
Commit-Queue: Wanming Lin <wanming.lin@intel.com>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#687130}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1737993 branch 7 times, most recently from 8005344 to 5024a0f Aug 6, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1737993 branch 2 times, most recently from 336c78f to 8841059 Aug 14, 2019
This CL enables all failure tests from wpt/web-nfc/(except the idlharness tests) with mock NFC
implementation, which automates all the manual tests at the same time.

Merge NFCWriter#push() relevant tests into one file: NFCWriter_push.https.html

Merge NFCReader relevant tests into two separate files: NFCReader.https.html and
NFCReader_options.https.html

BUG=520391

Change-Id: Iefc61b618bebcdc198dc4a2470350480b2cc2cd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737993
Commit-Queue: Wanming Lin <wanming.lin@intel.com>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#687130}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1737993 branch from 8841059 to f5cae31 Aug 15, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 0c69b97 into master Aug 15, 2019
15 checks passed
15 checks passed
update-pr-preview
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190815.16 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1737993 branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.