Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report image url for oversized/unoptimized images #18337

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 8, 2019

Add image url to FeaturePolicyViolationReportBody when there is a
oversized/unoptimized image feature policy violated. Previously the
fileSource field in report is set to null when policy is violated.

The effect is achieved by letting LocationReportBody represents both
a location in JavaScript source code and a location of a general
resource, e.g. a image. Because image does not have line number and
column number, these attrs are represented in optional value, and
LocationReportBody now saves pieces of actual information it needs
to generate the report, instead of a reference to SourceLocation.

Bug: 989701
Change-Id: Ibe88f07e7fa93c3d54b17380f8627221c119e106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741958
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#687829}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title add test for oversized-image reporting Add image url to FeaturePolicyViolationReportBody when there is a oversize image feature policy violated. Previously the fileSource field in report is set to null when policy is violated. Aug 9, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1741958 branch 3 times, most recently from e6be48d to bf6f18e Aug 9, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Add image url to FeaturePolicyViolationReportBody when there is a oversize image feature policy violated. Previously the fileSource field in report is set to null when policy is violated. Add image url to FeaturePolicyViolationReportBody when there is a oversize/unoptimized image feature policy violated. Previously the fileSource field in report is set to null when policy is violated. Aug 13, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1741958 branch 4 times, most recently from c84b55c to d3e5c77 Aug 13, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Add image url to FeaturePolicyViolationReportBody when there is a oversize/unoptimized image feature policy violated. Previously the fileSource field in report is set to null when policy is violated. Report image url for oversized/unoptimized images Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1741958 branch 3 times, most recently from a45edef to 8b5f819 Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1741958 branch from 8b5f819 to e84c25e Aug 16, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1741958 branch from e84c25e to 7dbb9cb Aug 16, 2019
Add image url to FeaturePolicyViolationReportBody when there is a
oversized/unoptimized image feature policy violated. Previously the
fileSource field in report is set to null when policy is violated.

The effect is achieved by letting LocationReportBody represents both
a location in JavaScript source code and a location of a general
resource, e.g. a image. Because image does not have line number and
column number, these attrs are represented in optional value, and
LocationReportBody now saves pieces of actual information it needs
to generate the report, instead of a reference to SourceLocation.

Bug: 989701
Change-Id: Ibe88f07e7fa93c3d54b17380f8627221c119e106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741958
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#687829}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a5424fd into master Aug 16, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190816.243 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1741958 branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.