Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cookie-store] Attempt of deflake remaining service worker tests #18340

Merged
merged 2 commits into from Aug 15, 2019

Conversation

@Hexcles
Copy link
Member

Hexcles commented Aug 8, 2019

These are the two remaining tests that were not fixed in #18324 .

Unfortunately, the two tests still seem a bit flaky with all the speculative fixes.

Hexcles added 2 commits Aug 7, 2019
This is a follow-up to
#18324

This change by itself isn't sufficient to deflake the two tests.
Move the event handler registration to the top scope of the service
worker (Chrome warning: "Event handler of ... event must be added on the
initial evaluation of worker script.").
@Hexcles
Copy link
Member Author

Hexcles commented Aug 8, 2019

Well, we got lucky this time -- stability check is green.

But locally I can still get some flaky results from Chrome Dev (with experimental features enabled) by ./wpt run --channel dev --verify chrome /cookie-store/serviceworker_cookieStore_subscriptions_eventhandler_attribute.tentative.https.html.

@Hexcles
Copy link
Member Author

Hexcles commented Aug 14, 2019

Copy link
Contributor

inexorabletash left a comment

oops, thanks for the ping.

LGTM!

@Hexcles Hexcles merged commit 909a104 into master Aug 15, 2019
17 checks passed
17 checks passed
website-build-and-publish website-build-and-publish
Details
manifest-build-and-tag manifest-build-and-tag
Details
update-pr-preview update-pr-preview
Details
update-pr-preview update-pr-preview
Details
update-pr-preview update-pr-preview
Details
update-pr-preview update-pr-preview
Details
update-pr-preview update-pr-preview
Details
Azure Pipelines Build #20190808.93 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@Hexcles Hexcles deleted the fix-cookiestore-tests2 branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.