Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use |LayoutBox::ContentLogicalHeight| value for atomic inline FlexBox. #18362

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 10, 2019

Before this CL, |LayoutBox::ComputeIntrinsicLogicalContentHeightUsing|
returns zero intrinsic size defined in |LayoutBox::IntrinsicSize|,
when atomic inline level flexbox's height is specified with
'height: min-content'.

Per spec, https://drafts.csswg.org/css-sizing/#valdef-width-min-content,

"min-content
If specified for the inline axis, use the min-content inline size;
otherwise compute to auto.",

'height' property specified with min-content should compute to 'auto',
i.e. the content's intrinsic size.

Bug: 959551
Change-Id: I798a07670036072bfd47bddb6bb0f88347eaa929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746507
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Joonghun Park <pjh0718@gmail.com>
Cr-Commit-Position: refs/heads/master@{#687203}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1746507 branch 3 times, most recently from b2eb45e to f809127 Aug 12, 2019
Before this CL, |LayoutBox::ComputeIntrinsicLogicalContentHeightUsing|
returns zero intrinsic size defined in |LayoutBox::IntrinsicSize|,
when atomic inline level flexbox's height is specified with
'height: min-content'.

Per spec, https://drafts.csswg.org/css-sizing/#valdef-width-min-content,

"min-content
If specified for the inline axis, use the min-content inline size;
otherwise compute to auto.",

'height' property specified with min-content should compute to 'auto',
i.e. the content's intrinsic size.

Bug: 959551
Change-Id: I798a07670036072bfd47bddb6bb0f88347eaa929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746507
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Joonghun Park <pjh0718@gmail.com>
Cr-Commit-Position: refs/heads/master@{#687203}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1746507 branch from f809127 to b712466 Aug 15, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit bda5bfb into master Aug 15, 2019
12 checks passed
12 checks passed
update-pr-preview
Details
wpt.fyi - chrome[experimental] Chrome results
Details
Azure Pipelines Build #20190815.65 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1746507 branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.