Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1231213] Update the update algorithm to better match the spec #18398

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Aug 13, 2019

  • Throw a TypeError when a registration isn't found in the "scope to registration map"
  • Synchronously (before enqueuing a job) check for an existing newest worker
  • Synchronously check if an installing worker is attempting to update itself

Differential Revision: https://phabricator.services.mozilla.com/D41618

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1231213
gecko-commit: 6f25a7e73fe202d3e1f9b12f8a0fe102f9513488
gecko-integration-branch: autoland
gecko-reviewers: asuth

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

- Throw a TypeError when a registration isn't found in the "scope to registration map"
- Synchronously (before enqueuing a job) check for an existing newest worker
- Synchronously check if an installing worker is attempting to update itself

Differential Revision: https://phabricator.services.mozilla.com/D41618

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1231213
gecko-commit: 8f031439c3bcc4c1f9a0859500c1bd22eaeb622c
gecko-integration-branch: autoland
gecko-reviewers: asuth
@moz-wptsync-bot moz-wptsync-bot force-pushed the gecko/1231213 branch from 49621d3 to 5435967 Aug 15, 2019
@moz-wptsync-bot moz-wptsync-bot merged commit 55a9dd6 into master Aug 16, 2019
13 of 14 checks passed
13 of 14 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
upstream/gecko Landed on mozilla-central
Details
Azure Pipelines Build #20190815.175 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1231213 branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.