Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite interpolation-testcommon.js #18402

Merged
merged 1 commit into from Aug 16, 2019
Merged

Rewrite interpolation-testcommon.js #18402

merged 1 commit into from Aug 16, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 13, 2019

Right now the wpt/css/support/interpolation-testcommon.js is very
specific to interpolations using CSS animations. As a result, it is
used by a few tests only.

This CL rewrites the file. To be more specific, most of the code comes
from web_tests/animations/interpolation/resources/interpolation-test.js,
which runs the tests with several interpolation methods:

  1. cssAnimationsInterpolation
  2. cssTransitionsInterpolation
  3. cssTransitionAllInterpolation
  4. webAnimationsInterpolation
    With this general test file, a lot of existing interpolation test can
    use this. Furthermore, the intention is to move non-wpt interpolation
    and composition tests to wpt using this file.

Bug: 900581
Change-Id: I1058c556932d28709bacdb08a4591c958aead937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752103
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687264}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1752103 branch 6 times, most recently from e6c01fc to 5c48a0b Aug 13, 2019
Right now the wpt/css/support/interpolation-testcommon.js is very
specific to interpolations using CSS animations. As a result, it is
used by a few tests only.

This CL rewrites the file. To be more specific, most of the code comes
from web_tests/animations/interpolation/resources/interpolation-test.js,
which runs the tests with several interpolation methods:
  1. cssAnimationsInterpolation
  2. cssTransitionsInterpolation
  3. cssTransitionAllInterpolation
  4. webAnimationsInterpolation
With this general test file, a lot of existing interpolation test can
use this. Furthermore, the intention is to move non-wpt interpolation
and composition tests to wpt using this file.

Bug: 900581
Change-Id: I1058c556932d28709bacdb08a4591c958aead937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752103
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687264}
@Hexcles
Copy link
Member

Hexcles commented Aug 16, 2019

@Hexcles Hexcles merged commit 92d4abd into master Aug 16, 2019
15 of 16 checks passed
15 of 16 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
Taskcluster (pull_request) TaskGroup: failure
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190815.142 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@Hexcles Hexcles deleted the chromium-export-cl-1752103 branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.