Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LargestContentfulPaint] Fix loadTime for background images #18404

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 13, 2019

This CL fixes the loadTime of background images for the LargestContentfulPaint
web API. The StyleFetchedImage is now needed in the OnImageLoaded() method.
Instead of computing the timestamp again, we query it from the
ImageElementTiming class. This should be populated whenever ElementTiming is
enabled. While it is still behind a flag, it is set to 'stable' so it should be
on by default. A test is added to ensure that the loadTime is populated properly
in a case where it wouldn't be previously.

Bug: 965505, 986891
Change-Id: I7c3421006cec0dbd79c50a21ae055f11b7ce3ce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752295
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687242}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1752295 branch 4 times, most recently from d6cc663 to 75bc4d1 Aug 13, 2019
This CL fixes the loadTime of background images for the LargestContentfulPaint
web API. The StyleFetchedImage is now needed in the OnImageLoaded() method.
Instead of computing the timestamp again, we query it from the
ImageElementTiming class. This should be populated whenever ElementTiming is
enabled. While it is still behind a flag, it is set to 'stable' so it should be
on by default. A test is added to ensure that the loadTime is populated properly
in a case where it wouldn't be previously.

Bug: 965505, 986891
Change-Id: I7c3421006cec0dbd79c50a21ae055f11b7ce3ce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752295
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687242}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1752295 branch from 75bc4d1 to bc98861 Aug 15, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit d9e65dc into master Aug 15, 2019
12 checks passed
12 checks passed
update-pr-preview
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190815.121 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1752295 branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.