Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: Shortest serialization for gap shorthand #18407

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 13, 2019

gap is <'row-gap'> <'column-gap'>?
https://drafts.csswg.org/css-align-3/#propdef-gap

If row-gap and column-gap are the same, we serialize
only a single value, consistent with Firefox and
the shortest representation principle.
https://drafts.csswg.org/cssom/#serializing-css-values

Change-Id: I8a2380d963cdbb7f33676b435d9cfb909abf9e77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750521
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686773}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

gap is <'row-gap'> <'column-gap'>?
https://drafts.csswg.org/css-align-3/#propdef-gap

If row-gap and column-gap are the same, we serialize
only a single value, consistent with Firefox and
the shortest representation principle.
https://drafts.csswg.org/cssom/#serializing-css-values

Change-Id: I8a2380d963cdbb7f33676b435d9cfb909abf9e77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750521
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686773}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1750521 branch from 3db3aff to 55c6cc2 Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a06709f into master Aug 14, 2019
14 of 16 checks passed
14 of 16 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190814.70 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1750521 branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.