Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPT tests for WebXR SameObject attributes #18410

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 13, 2019

Adding [SaveSameObject] and a reference to the attribute in
v8_private_property.h is required for the [SameObject] FrozenArray
attributes to have the expected behavior.

Attributes now covered by tests:
Navigator.xr
XRSession.{renderState,inputSources}
XRView.{projectionMatrix,transform}
XRRigidTransform.{position,orientation,inverse}
XRPose.transform
XRViewerPose.views
XRInputSource.{targetRaySpace,gripSpace,profiles}
XRWebGLLayer.framebuffer
XRSessionEvent.session
XRInputSourceEvent.{frame,inputSource}
XRInputSourcesChangeEvent.{session,added,removed}
XRReferenceSpaceEvent.{referenceSpace,transform}

Bug: 960958
Change-Id: I8582909c3e87ec0bfe05e443416708a54f606bd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752934
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687756}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1752934 branch 2 times, most recently from feecb7e to 84be25f Aug 13, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1752934 branch from 84be25f to da0ae6f Aug 16, 2019
Adding [SaveSameObject] and a reference to the attribute in
v8_private_property.h is required for the [SameObject] FrozenArray
attributes to have the expected behavior.

Attributes now covered by tests:
Navigator.xr
XRSession.{renderState,inputSources}
XRView.{projectionMatrix,transform}
XRRigidTransform.{position,orientation,inverse}
XRPose.transform
XRViewerPose.views
XRInputSource.{targetRaySpace,gripSpace,profiles}
XRWebGLLayer.framebuffer
XRSessionEvent.session
XRInputSourceEvent.{frame,inputSource}
XRInputSourcesChangeEvent.{session,added,removed}
XRReferenceSpaceEvent.{referenceSpace,transform}

Bug: 960958
Change-Id: I8582909c3e87ec0bfe05e443416708a54f606bd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752934
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687756}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1752934 branch from da0ae6f to 8c4fa40 Aug 16, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit b5a32d2 into master Aug 16, 2019
14 checks passed
14 checks passed
update-pr-preview
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190816.206 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1752934 branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.