Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LargestContentfulPaint] Re-enable untrusted scroll test #18411

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 13, 2019

The test was disabled because it landed too close to the change which changed
the startTime to not be 0. After addressing that change, the test now passes.

Bug: 987915
Change-Id: Id19623083aa141f7c3b541ad490db6395add6f8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753082
Auto-Submit: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686787}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

The test was disabled because it landed too close to the change which changed
the startTime to not be 0. After addressing that change, the test now passes.

Bug: 987915
Change-Id: Id19623083aa141f7c3b541ad490db6395add6f8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753082
Auto-Submit: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686787}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1753082 branch from 345ac5d to a149224 Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6c01d2d into master Aug 14, 2019
13 of 17 checks passed
13 of 17 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20190814.79 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1753082 branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.