Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebNFC] Distinguish between NFC not available and not enabled #18416

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 14, 2019

Following spec change at w3c/web-nfc#237, this
CL allows web developers to distinguish when NFC is not available and
when it's disabled by user preference.

Bug: 520391
Change-Id: I3927d855edef1b1cf9b2036a0b4991745b962e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751948
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#686762}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1751948 branch from 87c8bef to afefd88 Aug 14, 2019
Following spec change at w3c/web-nfc#237, this
CL allows web developers to distinguish when NFC is not available and
when it's disabled by user preference.

Bug: 520391
Change-Id: I3927d855edef1b1cf9b2036a0b4991745b962e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751948
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#686762}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1751948 branch from afefd88 to 9857b40 Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 33a1cca into master Aug 14, 2019
13 of 17 checks passed
13 of 17 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20190814.44 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1751948 branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.