Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make status neutral return code 0 so that jobs stop failing #18417

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@jgraham
Copy link
Contributor

jgraham commented Aug 14, 2019

GitHub seems to have broken the feature where an action returning
status 78 is deemed neutral, so to stop it looking like everything
failed, use a success status instead (i.e. return code 0); this
can be reverted when GitHub fix their bug.

GitHub seems to have broken the feature where an action returning
status 78 is deemed neutral, so to stop it looking like everything
failed, use a success status instead (i.e. return code 0); this
can be reverted when GitHub fix their bug.
Copy link
Contributor

jugglinmike left a comment

For those following along: we're tracking the problem with GitHub's functionality via gh-18392.

@jugglinmike jugglinmike reopened this Aug 14, 2019
@jugglinmike jugglinmike merged commit 70682ec into master Aug 14, 2019
23 of 27 checks passed
23 of 27 checks passed
update-pr-preview
Details
update-pr-preview
Details
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
update-pr-preview
Details
update-pr-preview
Details
update-pr-preview
Details
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20190814.31 failed
Details
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS failed
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (tools/ unittests: Windows Python 3) tools/ unittests: Windows Python 3 succeeded
Details
Azure Pipelines (tools/ unittests: Windows) tools/ unittests: Windows succeeded
Details
Azure Pipelines (tools/ unittests: macOS) tools/ unittests: macOS succeeded
Details
Azure Pipelines (tools/wpt/ tests: Windows) tools/wpt/ tests: Windows succeeded
Details
Azure Pipelines (tools/wpt/ tests: macOS) tools/wpt/ tests: macOS succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: Windows) tools/wptrunner/ unittests: Windows succeeded
Details
Azure Pipelines (tools/wptrunner/ unittests: macOS) tools/wptrunner/ unittests: macOS succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
@jugglinmike jugglinmike deleted the success_is_neutral branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.