Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use observer for sync bases #18419

Merged
merged 1 commit into from Aug 14, 2019
Merged

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 14, 2019

Previously sync bases would not be updated if the base element was
swapped out. This has been changed to allow for this. Making events
and sync bases work more uniformly.

This is the first step in changing sync base repeats into actual
sync bases.

Bug: 993702
Change-Id: I1a1b381d094100296a420de8877bb1e57cd9709e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753004
Commit-Queue: Edvard Thörnros <edvardt@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Auto-Submit: Edvard Thörnros <edvardt@opera.com>
Cr-Commit-Position: refs/heads/master@{#686838}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Add observer for sync bases Use observer for sync bases Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1753004 branch 3 times, most recently from c3d2a62 to 90efa06 Aug 14, 2019
Previously sync bases would not be updated if the base element was
swapped out. This has been changed to allow for this. Making events
and sync bases work more uniformly.

This is the first step in changing sync base repeats into actual
sync bases.

Bug: 993702
Change-Id: I1a1b381d094100296a420de8877bb1e57cd9709e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753004
Commit-Queue: Edvard Thörnros <edvardt@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Auto-Submit: Edvard Thörnros <edvardt@opera.com>
Cr-Commit-Position: refs/heads/master@{#686838}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1753004 branch from 90efa06 to 89a6b5b Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 5777568 into master Aug 14, 2019
17 checks passed
17 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
update-pr-preview
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190814.111 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1753004 branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.