Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1571764] Subtract combobox display frame border-padding when inferring the height from line-height. #18426

Merged
merged 2 commits into from Aug 15, 2019

Conversation

@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Aug 14, 2019

This fixes it and seems to be an acceptable fix... Should I make it conditional
on box-sizing: border-box for completeness? The display frame has border-box
box-sizing, and not having it would be a bug, I'd think...

Differential Revision: https://phabricator.services.mozilla.com/D41939

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1571764
gecko-commit: bd44d2dd0c02c1e2ab10e73695ee3ef1da971aa6
gecko-integration-branch: autoland
gecko-reviewers: mats, jfkthame

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

…ght from line-height.

This fixes it and seems to be an acceptable fix... Should I make it conditional
on box-sizing: border-box for completeness?  The display frame has border-box
box-sizing, and not having it would be a bug, I'd think...

Differential Revision: https://phabricator.services.mozilla.com/D41939

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1571764
gecko-commit: ad04c84153da637000c7a472ccbc248116b5c330
gecko-integration-branch: autoland
gecko-reviewers: mats, jfkthame
@moz-wptsync-bot moz-wptsync-bot force-pushed the gecko/1571764 branch from ade474e to e039d72 Aug 15, 2019
…have border-radius.

MANUAL PUSH: Orange

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1571764
gecko-commit: bd8ef39cfadc0e427b1261ae8b2b2f7677d85bd2
gecko-integration-branch: autoland
@moz-wptsync-bot moz-wptsync-bot merged commit 95fc0af into master Aug 15, 2019
13 of 14 checks passed
13 of 14 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
upstream/gecko Landed on mozilla-central
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190815.104 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - chrome[experimental] Chrome results
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1571764 branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.