Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ChromeDriver] Creates new ChromeDriver SetPermission command #18429

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Aug 14, 2019

Adds W3C WebDriver extension, SetPermission, to support simple
permissions.

Design doc: go/chromedriver-permissions-ext

of the spec, the tests do not test much, so new tests were added to
run_py_tests to enfore certain behaviors.

Tested: Passing W3C permissions tests. Due to the relaxed definition
Bug: chromedriver:2212
Change-Id: Ie61cc4c0e18c714f93ac7ab918d0cec0e4210e1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666438
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Rohan Pavone <rohpavone@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690496}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1666438 branch 9 times, most recently from ffb147b to 96a1b46 Aug 21, 2019
Adds W3C WebDriver extension, SetPermission, to support simple
permissions.

Design doc: go/chromedriver-permissions-ext

of the spec, the tests do not test much, so new tests were added to
run_py_tests to enfore certain behaviors.

Tested: Passing W3C permissions tests. Due to the relaxed definition
Bug: chromedriver:2212
Change-Id: Ie61cc4c0e18c714f93ac7ab918d0cec0e4210e1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666438
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Rohan Pavone <rohpavone@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690496}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1666438 branch from 96a1b46 to ca26bfa Aug 26, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f4a5e48 into master Aug 26, 2019
16 checks passed
16 checks passed
website-build-and-publish
Details
manifest-build-and-tag
Details
update-pr-preview
Details
Azure Pipelines Build #20190826.105 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1666438 branch Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.